Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuring Jackson's TimeZone via configuration #15431

Merged
merged 2 commits into from
Mar 4, 2021
Merged

Allow configuring Jackson's TimeZone via configuration #15431

merged 2 commits into from
Mar 4, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Mar 3, 2021

Fixes: #15077

@geoand geoand requested a review from gsmet March 3, 2021 10:54
gsmet
gsmet reviewed Mar 3, 2021
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a question inline.

extensions/jackson/deployment/src/main/java/io/quarkus/jackson/deployment/JacksonProcessor.java Outdated Show resolved Hide resolved
gsmet
gsmet approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool now and paves the way for future timezone settings.

@geoand
Copy link
Contributor Author

geoand commented Mar 3, 2021

Yeah, your idea about ZoneId really made the difference!

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 3, 2021
@gsmet
Copy link
Member

gsmet commented Mar 3, 2021

Something is not right:

Caused by: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.<clinit>(ApplicationImpl.zig:315)
	... 15 more
Caused by: java.lang.NoClassDefFoundError: io/quarkus/deployment/recording/substitutions/ZoneIdSubstitution
	at io.quarkus.deployment.steps.JacksonProcessor$pushConfigurationBean290634148.deploy_0(JacksonProcessor$pushConfigurationBean290634148.zig:62)
	at io.quarkus.deployment.steps.JacksonProcessor$pushConfigurationBean290634148.deploy(JacksonProcessor$pushConfigurationBean290634148.zig:40)
	at io.quarkus.runner.ApplicationImpl.<clinit>(ApplicationImpl.zig:163)
	... 15 more
The output of the Quarkus build can be found at /home/runner/work/quarkus/quarkus/integration-tests/hibernate-orm-panache/target/quarkus-prod-mode-test438526196068243597/build-result
Caused by: java.lang.ClassNotFoundException: io.quarkus.deployment.recording.substitutions.ZoneIdSubstitution
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
	at io.quarkus.bootstrap.runner.RunnerClassLoader.loadClass(RunnerClassLoader.java:104)
	at io.quarkus.bootstrap.runner.RunnerClassLoader.loadClass(RunnerClassLoader.java:60)
	... 18 more

@geoand
Copy link
Contributor Author

geoand commented Mar 3, 2021

Ouch...

I'll have to take a closer look

@geoand
Copy link
Contributor Author

geoand commented Mar 3, 2021

Should be good now

@geoand geoand merged commit 0717498 into quarkusio:master Mar 4, 2021
@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Mar 4, 2021
@geoand geoand deleted the #15077 branch March 4, 2021 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machi1990 machi1990 machi1990 approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/config area/core triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.13.0.CR1
Development

Successfully merging this pull request may close these issues.

timezone setting for jackson in application.properties
3 participants
@geoand @gsmet @machi1990